Better dedupe (#134)

O-Mutt · Jul 12, 2023 · 7b03c03 · 7b03c03
1 parent 8fa220a
commit 7b03c03
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
 	"name": "hubot-plusplus-expanded",
-	"version": "3.4.11",
+	"version": "3.4.12",
 	"description": "A hubot script for micro praise",
 	"main": "index.js",
 	"engines": {

diff --git a/src/help.js b/src/help.js
@@ -21,7 +21,7 @@ module.exports = function help(robot) {
 
   robot.respond(RegExpPlusPlus.getHelp(), respondWithHelpGuidance);
   robot.respond(new RegExp(/(plusplus version|-v|--version)/, 'i'), (msg) => {
-    msg.send(`${Helpers.capitalizeFirstLetter(msg.robot.name)} [${pjson.name}](${pjson.repository.url}): [v${pjson.version}](https://www.npmjs.com/package/${pjson.name}).`);
+    msg.send(`${Helpers.capitalizeFirstLetter(msg.robot.name)} <${pjson.repository.url}|${pjson.name}> <https://www.npmjs.com/package/${pjson.name}|v${pjson.version}>.`);
   });
 
   robot.hear(new RegExp('how much .*point.*', 'i'), tellHowMuchPointsAreWorth);

diff --git a/src/messageHandlers/plusplus.js b/src/messageHandlers/plusplus.js
@@ -126,7 +126,7 @@ module.exports = function plusplus(robot) {
     if (mentions) {
       to = mentions
         .filter((men) => men.type === 'user')
-        .filter((men, pos, self) => self.indexOf(s => s.id === men.id) === pos);
+        .filter((single, index, allMentions) => index === allMentions.findIndex((m) => m.id === single.id));
     }
     const cleanReason = Helpers.cleanAndEncode(reason);
     const increment = operator.match(RegExpPlusPlus.positiveOperators) ? 1 : -1;