Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate HttplugFactory and make dependency on php-http/message-factory optional #243

Merged
merged 1 commit into from
May 2, 2023
Merged

Deprecate HttplugFactory and make dependency on php-http/message-factory optional #243

merged 1 commit into from
May 2, 2023

Conversation

murat11
Copy link
Contributor

@murat11 murat11 commented Apr 26, 2023 •
edited by nicolas-grekas
Loading

@nicolas-grekas

This comment was marked as resolved.

Sign in to view
@murat11 murat11 force-pushed the get-rid-of-dependency-from-deprecated-phphttp-message-factory branch from e02a76d to 38af5e1 Compare April 27, 2023 05:24
@nicolas-grekas nicolas-grekas changed the title Get rid of dependency from deprecated php-http/message-factory Deprecate HttplugFactory Apr 27, 2023
@nicolas-grekas nicolas-grekas force-pushed the get-rid-of-dependency-from-deprecated-phphttp-message-factory branch from 38af5e1 to e19cf76 Compare April 27, 2023 07:27
@nicolas-grekas nicolas-grekas changed the title Deprecate HttplugFactory Deprecate HttplugFactory and make depencendy on php-http/message-factory optional Apr 27, 2023
@nicolas-grekas nicolas-grekas force-pushed the get-rid-of-dependency-from-deprecated-phphttp-message-factory branch from e19cf76 to fa7c765 Compare April 27, 2023 07:28
nicolas-grekas
nicolas-grekas approved these changes Apr 27, 2023
View reviewed changes
Copy link
Collaborator

@nicolas-grekas nicolas-grekas left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the patch to account for a few more things, especially making the dependency on php-http/message-factory optional.

@nicolas-grekas nicolas-grekas force-pushed the get-rid-of-dependency-from-deprecated-phphttp-message-factory branch from fa7c765 to 993e7bb Compare April 27, 2023 18:16
@nicolas-grekas nicolas-grekas changed the title Deprecate HttplugFactory and make depencendy on php-http/message-factory optional Deprecate HttplugFactory and make dependency on php-http/message-factory optional May 2, 2023
@nicolas-grekas nicolas-grekas force-pushed the get-rid-of-dependency-from-deprecated-phphttp-message-factory branch from 993e7bb to 8a3cb64 Compare May 2, 2023 11:15
@nicolas-grekas nicolas-grekas mentioned this pull request May 2, 2023
Merged
@nicolas-grekas nicolas-grekas merged commit 3cb4d16 into Nyholm:master May 2, 2023
11 of 12 checks passed
@nicolas-grekas
Copy link
Collaborator

Thank you @murat11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@murat11 @nicolas-grekas