Fix boundary case behavior for buffer movement (Circular rotation)#526
Open
raindealer wants to merge 1 commit intoNvChad:v3.0from
Open
Fix boundary case behavior for buffer movement (Circular rotation)#526raindealer wants to merge 1 commit intoNvChad:v3.0from
raindealer wants to merge 1 commit intoNvChad:v3.0from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello! I often use your plugin, and the current boundary case behavior is a bit annoying. When moving the first buffer to the left or the last buffer to the right, we shouldn't just swap their places. Instead, we should move the first element to the very end (or vice versa) without swapping it with the neighbor.
Current behavior (Simple Swap):

State 1:
State 2:
New behavior (Circular Rotation):

State 1:
State 2:
Attention on the second and pre-last elements the entire list shifts to maintain order.