Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added Dockerfile for local dev #16

Closed
wants to merge 2 commits into from
Closed

added Dockerfile for local dev #16

wants to merge 2 commits into from

Conversation

jimkring
Copy link

@jimkring jimkring commented Feb 25, 2024 •
edited
Loading

Added a docker folder with Dockerfile and a couple scripts to make dev easier.

to use:

cd docker
./build.sh
./run.sh

the run.sh command will start a terminal in the container.

sourcery-ai[bot]
sourcery-ai bot reviewed Feb 25, 2024
View reviewed changes
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Type: Enhancement

PR Summary: The pull request introduces a Docker environment setup for local development, including a Dockerfile and scripts for building and running a Docker container. This setup aims to simplify the development process by encapsulating dependencies and the development environment within a Docker container.

Decision: Comment

📝 Type: 'Enhancement' - not supported yet.
  • Sourcery currently only approves 'Typo fix' PRs.
✅ Issue addressed: this change correctly addresses the issue or implements the desired feature.
No details provided.
✅ Small diff: the diff is small enough to approve with confidence.
No details provided.

General suggestions:

  • Consider optimizing the Dockerfile by combining RUN instructions to reduce the number of layers created. This can lead to a smaller Docker image size and faster build times.
  • Ensure that the documentation or README is updated to include instructions on how to use the Docker setup for new or existing developers.
  • Review the naming convention of the Docker tag in the build script to ensure it aligns with project standards or versioning schemes.

Thanks for using Sourcery. We offer it for free for open source projects and would be very grateful if you could help us grow. If you like it, would you consider sharing Sourcery on your favourite social media? ✨

Share Sourcery

Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

docker/Dockerfile

# 'Development Tools' group is the equivalent of 'build-essential' package in Ubuntu
RUN echo "Installing Development Tools"
RUN yum install -y perl-IPC-Cmd gperf git
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion (llm): Consider combining RUN instructions to reduce the number of layers in the Docker image. This can be achieved by chaining commands using '&&' and cleaning up in the same layer to optimize the image size.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great idea!

@jimkring jimkring closed this Feb 25, 2024
@jimkring
Copy link
Author

going to close this since I'm not proposing we merge this

@jimkring jimkring deleted the 3.11-docker branch February 25, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jimkring