Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/update nearcore 2.4.0 rc2 #323

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

serrrfirat
Copy link
Collaborator

@serrrfirat serrrfirat commented Jan 9, 2025

Current Behavior

New Behavior

Breaking Changes

Observations


This change is Reviewable

Summary by CodeRabbit

  • Chores
    • Updated dependencies for near-indexer, near-client, near-o11y, near-config-utils, near-client-primitives, and near-crypto to the latest commit from the nearcore repository.

Copy link
Contributor

coderabbitai bot commented Jan 9, 2025

📝 Walkthrough

Walkthrough

The pull request updates the Cargo.toml file for the indexer package by changing the Git commit references for multiple Near-related dependencies. Specifically, the commit hash for dependencies like near-indexer, near-client, near-o11y, and others has been updated from a83c18490cf4dafaedca01458f365dc5871bd293 to 53063d8e9bfdb06d397a8d1a4c6e341091f144d6, all sourced from the nearcore GitHub repository.

Changes

File Change Summary
indexer/Cargo.toml Updated Git commit references for Near dependencies:
- near-indexer
- near-client
- near-o11y
- near-config-utils
- near-client-primitives
- near-crypto

No further elaboration is necessary. The changes are straightforward dependency updates.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ded9150 and bf918cd.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • indexer/Cargo.toml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (4)
  • GitHub Check: Integration Test
  • GitHub Check: run-docker-compose
  • GitHub Check: run-docker-compose-with-fastnear
  • GitHub Check: Rust Unit Tests
🔇 Additional comments (3)
indexer/Cargo.toml (3)

30-34: Document the update and potential breaking changes

The PR description is empty. You must document:

  1. What version of nearcore this updates from/to
  2. Any breaking changes that need attention
  3. Required testing steps

This is especially important since:

  • You're updating to a Release Candidate version
  • These are core dependencies that could affect the entire indexer functionality

Also applies to: 41-41


30-34: Ensure consistent dependency versions

Good: All near-related dependencies are using the same commit hash, which is essential for compatibility.

Also applies to: 41-41


30-34: Verify this is the correct nearcore 2.4.0-rc2 commit hash

The PR title indicates this is an update to nearcore 2.4.0-rc2, but we need to verify this commit hash is actually from that release.

Let's verify the commit hash against the nearcore repository:

Also applies to: 41-41

✅ Verification successful

Commit hash verified for nearcore 2.4.0-rc2

All near-* dependencies are consistently using the correct commit hash for nearcore 2.4.0-rc2. The commit includes an epoch sync fix that doesn't introduce breaking changes.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the commit hash corresponds to nearcore 2.4.0-rc2
# and check for any breaking changes in the release notes

# Check if this commit exists and get its details
gh api repos/near/nearcore/commits/53063d8e9bfdb06d397a8d1a4c6e341091f144d6 --jq '.commit.message'

# Check for tags/releases around this commit
gh api repos/near/nearcore/tags --jq '.[] | select(.commit.sha | startswith("53063d8e"))'

Length of output: 1676


Script:

#!/bin/bash
# Check for any other near-* dependencies that might need updating
rg "near-.*git.*nearcore" -A 1 -B 1 indexer/Cargo.toml

# Also check workspace Cargo.toml if it exists
fd "Cargo.toml" --max-depth 1 --exec rg "near-.*git.*nearcore" -A 1 -B 1 {}

Length of output: 887

Finishing Touches

  • 📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@serrrfirat serrrfirat self-assigned this Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant