Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge main into testnet-0 #315

Closed
wants to merge 12 commits into from
Closed

Merge main into testnet-0 #315

wants to merge 12 commits into from

Conversation

Fly-Style
Copy link
Contributor

@Fly-Style Fly-Style commented Nov 19, 2024

This change is Reviewable

Hyodar and others added 10 commits October 3, 2024 22:19
* test: Add RollupOperators related tests

* test: Add ServiceManager and TaskManager trivial tests

* feat: Remove unused getter

* refactor: Comment unused variable name

* test: Add SFFLOperatorSetUpdateRegistry tests

* chore: Update bindings
* Operator set update script

* State Root update script

* Add script to get storage value

* Integrate rlp package for encoding

* Add demo nffl cli tool

* Get private key from environment variable

* chore: Restructure nffl-cli directories

* refactor: Port CLI to TS

* docs: Add README to demo CLI

* feat: Add block-height arg to storage-proof

* feat: Add commands as npm scripts

* chore: Update ABI

---------

Co-authored-by: Franco Barpp Gomes <[email protected]>
Fixing typos and readability

Co-authored-by: Don <[email protected]>
This patch adds Verifier V1 component as a part of DVN. In case, if received Packet was not verified, Verifier executes V1 verification algorithm:

- fetches state root from aggregator;
- fetches block state root by chain RPC API;
- compares them and says is message is gud.

As a part of this change, compilation error was fixed in indexer tests.
This patch adds `Executor` role to `NFFL` as well as an integration test for it
Enhanced testing capabilities by introducing separate and conditional jobs for Go and Rust unit tests in the CI workflow.
Updated the existing test job to improve clarity and structure.
Modified a test to indicate that a variable's return value is intentionally ignored.
Changes addressed previous FIXMEs, including:
- Move DVN components around so it's more modular
- Fix a minor bug on the executor, where the `provider` went
out of scope and stopped listening.
- Add some tests for the DVN.
Copy link
Contributor

coderabbitai bot commented Nov 19, 2024

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

dependabot bot and others added 2 commits November 19, 2024 16:42
Bumps [github.com/docker/docker](https://github.com/docker/docker) from 25.0.5+incompatible to 25.0.6+incompatible.
@Fly-Style Fly-Style closed this Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants