Contract refactorings and test improvements #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Currently, there is one formatting 'issue' in the contracts and there are also some test paths that are not followed for triviality. Now, considering we're moving closer to audits, it's best to maximize the coverage either way, so these testing paths should be considered.
New Behavior
This adds easy tests to improve coverage in some paths, fixes the formatting issue on an unused function argument and removes an unused getter.
Breaking Changes
There was a change in a contracts' API for removing an unused getter, but subjectively it should not be considered a breaking change at this point. Does not require a contract upgrade.