Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix occasional crash #99

Merged
merged 3 commits into from
Apr 18, 2024
Merged

fix occasional crash #99

merged 3 commits into from
Apr 18, 2024

Conversation

iavl
Copy link
Contributor

@iavl iavl commented Apr 12, 2024 •
edited
Loading

This PR fixes 2 possible issues

  1. submit_batch may fail for 2 reasons, thus causes the return value maybeFrameRef to be empty and invalid pointer will be found
  • da key has no permission to submit blobs to the blob store contract
  • da key has no allowance to pay for the gas
  1. GetDAError will free a null pointer when errData is empty

@iavl iavl requested a review from dndll as a code owner April 12, 2024 00:38
dndll
dndll previously approved these changes Apr 15, 2024
View reviewed changes
Copy link
Collaborator

@dndll dndll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great spot!

@firatNEAR
Copy link
Contributor

gopkg seems to fail the build, once that is passing we can merge this PR.

@dndll dndll merged commit 8daf926 into Nuffle-Labs:main Apr 18, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dndll dndll dndll left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iavl @firatNEAR @dndll