Custom url #98
Merged
Custom url #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
firatNEAR
approved these changes
Apr 10, 2024
dndll
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apologies that it went through couple iterations, motivation for this is:
We have a use case when we deploy services in containers, hence indexer gets its own IP. At this point communicating with it from da-rpc using 127.0.0.1 fails since it(da-rpc) is deployed in another container -
relayer.This PR intends to address this issue, requiring one to just provide
customurl to the node. This allows such usages:http://near-sffl-indexer:3030
http://ip:port