-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: kzg commitments over rs encoded grids #53
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dndll
force-pushed
the
feat/2d-interleaved-codes
branch
4 times, most recently
from
November 2, 2023 15:12
308e8ef
to
a4745b6
Compare
dndll
force-pushed
the
feat/2d-interleaved-codes
branch
2 times, most recently
from
November 13, 2023 13:08
53c4c05
to
3a4efd1
Compare
dndll
force-pushed
the
feat/2d-interleaved-codes
branch
from
November 13, 2023 13:11
3a4efd1
to
a494fce
Compare
8 tasks
dndll
force-pushed
the
feat/2d-interleaved-codes
branch
4 times, most recently
from
November 14, 2023 11:39
e850dd4
to
616b45b
Compare
dndll
force-pushed
the
feat/2d-interleaved-codes
branch
from
November 14, 2023 11:45
616b45b
to
39a4231
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introduces a KZG erasure commitment scheme over 2D reed-solomon codes with perfect squares. Commits to each row in the matrix, ready for disseminating (fields, proofs) to DAS nodes. Sampling these DAS nodes, we can easily verify the proof provided and determine if the DAS node is colluding quite quickly.
With the provided interface, we can quickly drop in new schemes, such as a Homormorphic Hash based commitment scheme. This is required when we consider DAS requirements on the network.
We should, in the future, abstract away the erasure coding, as we don't always need an MDS code for efficient schemes.
I will utilise this for
da-client
in another PR, which also requires deciding on a trusted setup and how to commit the root to L1. We can probably get away with one root commitment, compressing the point and posting that, but needs more investigation. I've also removed the point compression as Lambdaworks might implement point compression and endianness serialization soon. Related work https://github.com/lambdaclass/lambdaworks/blob/main/crypto/src/commitments/kzg.rs#L52 & lambdaclass/lambdaworks#323Other:
Bumps major version due to: