optimize contract

[encody]

#28

[encody]

Requires explicit borsh dependency because the version included in near-sdk does not allow us to remove std feature flag.

[dndll]

Looks great for contract storage costs, Do we know exactly how much gas this will reduce the calls by? Would be nice to take some call from throwawaykey.testnet and give it a test to ensure this actually does do better gas-cost-wise. The other part of this would involve touching da-rpc to serialise the data with borsh before we send it over.

[encody]

NEAR smart contracts cannot be built on Rust versions newer than 1.69 (you get a deserialization error from the node).

[dndll]

NEAR smart contracts cannot be built on Rust versions newer than 1.69 (you get a deserialization error from the node).

This was fixed actually. It just doesn't work for sandboxes-rs. I've been building and deploying with this environment for as long as I've been working on the project. (I think the issue is only instantiation)

[encody]

@dndll Ah, workspaces just fixed it, but released under a different name for some reason (workspaces -> near-workspaces). https://crates.io/crates/near-workspaces

[encody]

I did some simple tests locally.

Test	Gas cost
main branch (1 blob)	5.8 TGas
this branch (1 blob)	5.3 TGas
main branch (100 blobs)	15.1 TGas
this branch (100 blobs)	6.0 TGas

[firatNEAR]

LGTM, but would be good if @dndll takes another look.

[dndll]

This is great, but we are still missing the modifications to the rust client, right now this update would break such.

[dndll]

Please could you update the da-rpc client to support this change to the submit API? (it should be incredibly simple)

[firatNEAR]

@encody could we get this PR in soon? Is there anything that we can do to help? We are looking to audit the contract as soon as possible after this change is in.

[dndll]

new changes look good!

[dndll]

This test that is failing is because it used to be serialised with json and now not. Let's just put an ignore marker on that test since we don't have integration tests and this is a chicken and egg scenario