-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fix put route #123
chore: fix put route #123
Conversation
WalkthroughThe primary change involves modifying the route definition for the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- bin/sidecar/src/main.rs (1 hunks)
Additional comments not posted (1)
bin/sidecar/src/main.rs (1)
222-222
: Verify the impact of adding a trailing slash to the route path.Adding a trailing slash to the route path can affect how the endpoint is matched. Ensure that there are no unintended side effects and that the change is consistent across the codebase.
Verification successful
Verified the impact of adding a trailing slash to the route path.
The change to add a trailing slash to the
/plasma/put
route path has been verified. No unintended side effects or inconsistencies were found across the codebase and documentation.
- Only the route definition at
bin/sidecar/src/main.rs
was affected.- No dynamic route handling or documentation references were impacted.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify references to the `/plasma/put` route in the codebase. # Test: Search for references to the `/plasma/put` route. Expect: Consistent usage of the new route path with trailing slash. rg --type rust -A 5 $'/plasma/put'Length of output: 489
Script:
#!/bin/bash # Description: Verify if there are any dynamic references or documentation mentions of the `/plasma/put` route. # Test 1: Search for dynamic route handling in Rust files. rg --type rust 'plasma::submit' # Test 2: Search for mentions of the `/plasma/put` route in markdown files. rg --type md '/plasma/put'Length of output: 144
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's use a middleware built into axum - NormalizePathLayer tokio-rs/axum#2377
Following [this comment](#123 (review)), added a middleware to normalize the path of the route.
Following [this comment](#123 (review)), added a middleware to normalize the path of the route.
OP sends POST request to
/put/
, impl hereThis change is
Summary by CodeRabbit
/plasma/put
endpoint by adding a trailing slash to ensure proper functionality.