Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plasma): alt-da requires only commitments to be encoded in hexadecimal #122

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

dndll
Copy link
Collaborator

@dndll dndll commented Jul 10, 2024

Tested with copypaste of the batcher client. For Future reference: https://github.com/ethereum-optimism/specs/blob/8efc7a3fe800367bb8f407ab4fe284570a18ebc9/specs/experimental/alt-da.md?plain=1#L99-L129 Is the specification, unfortunately the batcher client expects a raw utf8 bytearray over the wire.

HTTP/1.1 200 OK
content-type: application/octet-stream
date: Wed, 10 Jul 2024 13:00:35 GMT
transfer-encoding: chunked

n[T����gL#3�Z�I'Co��JX�?�OT`�

Not a hex encoded commitment. Notably, they do encode it further downstream for the eth tx, so I wonder if they are doubling their commitment sizes if people are encoding at source and they are reencoding before sending to eth. Or perhaps I was stupid enough to be the only person who blindly followed the spec.

This change is Reviewable

@dndll dndll force-pushed the fix/plasma-invariant branch from 8959d54 to c98a818 Compare July 10, 2024 12:50
@dndll dndll changed the title fix(plasma): alt-da spec is inconsistent, follow it fix(plasma): alt-da requires only commitments to be encoded in hexadecimal Jul 10, 2024
@dndll dndll force-pushed the fix/plasma-invariant branch from c98a818 to 91f2284 Compare July 10, 2024 13:07
@dndll dndll merged commit de9ed25 into main Jul 10, 2024
4 of 5 checks passed
@dndll dndll deleted the fix/plasma-invariant branch July 10, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant