fix(plasma): alt-da requires only commitments to be encoded in hexadecimal #122
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested with copypaste of the batcher client. For Future reference: https://github.com/ethereum-optimism/specs/blob/8efc7a3fe800367bb8f407ab4fe284570a18ebc9/specs/experimental/alt-da.md?plain=1#L99-L129 Is the specification, unfortunately the batcher client expects a raw utf8 bytearray over the wire.
Not a hex encoded commitment. Notably, they do encode it further downstream for the eth tx, so I wonder if they are doubling their commitment sizes if people are encoding at source and they are reencoding before sending to eth. Or perhaps I was stupid enough to be the only person who blindly followed the spec.
This change is