Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new basic ci pipeline #10215

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from
Draft

Add new basic ci pipeline #10215

wants to merge 10 commits into from

Conversation

clairernovotny
Copy link
Contributor

Add a new CI pipeline that can cover CI and PRs on a public pool

Fixes https://github.com/NuGet/Engineering/issues/5246

@clairernovotny clairernovotny requested a review from a team as a code owner October 10, 2024 15:21
erdembayar
erdembayar reviewed Oct 10, 2024
View reviewed changes
.pipelines/ci.yml
nugetMultiFeedWarnLevel: none

pool:
vmImage: 'windows-latest'
Copy link
Contributor

@erdembayar erdembayar Oct 10, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is using different pool than existing NuGetGallery-CI.yml file. Why? Any reason?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The existing pool isn't meant for public builds

erdembayar
erdembayar reviewed Oct 10, 2024
View reviewed changes
.pipelines/ci.yml
@@ -0,0 +1,166 @@
name: NuGetGallery CI $(Build.BuildId)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we use 1ES template?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not for the public build as it's going to in dceng-public

@erdembayar
Copy link
Contributor

Could you please compare it to NuGetGallery-CI.yml make it close as possible? It would reduce maintenance work later for us.

@erdembayar
Copy link
Contributor

Also, it's not clear where the gatekeeper of the CI pipeline build is located. Do we have an approval process for community PR?

@erdembayar
Copy link
Contributor

Also, it's not clear where the gatekeeper of the CI pipeline build is located. Do we have an approval process for community PR?

Please change to dev instead of main for target brabch.

@erdembayar
Copy link
Contributor

@clairernovotny
CI build is broken. Should we force merge to main since this is a CI pipeline change?

@erdembayar
Copy link
Contributor

As team policy changing to draft until comments are addressed and CI build is green.

@erdembayar erdembayar marked this pull request as draft December 3, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erdembayar erdembayar erdembayar left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clairernovotny @erdembayar