Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modifying PostCSS Config To Fix Duplicating CSS #259

Merged
merged 2 commits into from
Dec 11, 2024

Conversation

Woedenaz
Copy link
Contributor

@Woedenaz Woedenaz commented Dec 11, 2024

Fixing the duplicating code issue by ensuring the plugin is not run async and does not use a temp room. This appears to fix the problem.

Fixes #258

Fixing the duplicating code issue by ensuring the plugin is not run async and does not use a temp room. This appears to fix the problem.
@Woedenaz Woedenaz changed the title Modifying PostCSS Config Modifying PostCSS Config To Fix Duplicating CSS Dec 11, 2024
@Woedenaz
Copy link
Contributor Author

I just realized it is not properly Bundling ./parts/fonts.css so I need to fix that first.

Copy link
Member

@emmiegit emmiegit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Removed custom LightningCSS bundler plugin and added back in the PostCSS Import plugin.
@Woedenaz Woedenaz merged commit c55112c into master Dec 11, 2024
1 check passed
@Woedenaz Woedenaz deleted the Duplicating-Code-Fix branch December 11, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The minified version of the theme's CSS contains duplicate chunks of code
2 participants