Bun migration #233
Merged
Bun migration #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bun is just *really fast* and I enjoy using it. I have no issues running it on my local machine but I need to see if it will work just as well when deployed on github
Just better practice to commit the lock file and include it in the `node_module` requirements.
Just for consistency.
These were broken when switching to bun. Changing them to Shell environment variables. I am unsure if these will work outside of Linux/Mac so I may need to find a better solution.
Remembered that `cross-env` fixes the exact issue I gave in the last push with Mac/Linux and Windows having different environment variable formats.
emmiegit
approved these changes
Dec 20, 2023
Co-authored-by: emmiegit <[email protected]>
Co-authored-by: emmiegit <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not exactly something that needed to be done but the build process when using
bunis insanely fast and it removes the requirement to install both node and pnpm, since it's able to replace both.It appears to be working fine when deployed but a second set of eyes would be appreciated!