-
Notifications
You must be signed in to change notification settings - Fork 606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add destroyColumn, renameColumn, and destroyTable migration steps #1799
base: master
Are you sure you want to change the base?
Conversation
added destroy table migration step as well |
@skam22 Thank you for your contribution! I'm seeing some issues, and I'd like to have this feature finished and shipped, so I took the liberty to add more commits to your PR. Thanks! |
ok let me know if you need help with anything. |
Somewhat related to this PR but it would be nice to be able to reset the entire db (schema, lastPulledAt and all) during/instead of migrations as well so that the backend can be the main source of data and migrations can be simplified for apps that don't require the full offline functionality. I created an issue to ask about it awhile back: #1609 |
…destroy indexed columns
@radex resolved conflicts |
@radex fwiw I was able to run the tests locally with success by changing the iPhone model to 15 instead of 14 (as is required for Xcode 15.4). scripts/test-ios #!/bin/bash
set -x
set -e
xcodebuild -workspace native/iosTest/WatermelonTester.xcworkspace -scheme 'WatermelonTester' -destination 'name=iPhone 15' test
|
This PR implements most of the outstanding code changes from
#1671 and #1654.
In addition to resolving those conflicts it has a few minor syntactic / grammatical fixes to match the existing migration approaches.