Tauri adapter #1758
Draft
Tauri adapter #1758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix import Add types for sql plugin import Tauri target
ospfranco
commented
Mar 11, 2024
| @@ -1,7 +1,7 @@ | |||
| // @flow | |||
| /* eslint-disable global-require */ | |||
|
|
|||
| import DatabaseBridge from '../sqlite-node/DatabaseBridge' | |||
There was a problem hiding this comment.
This path is hardcoded for node and I just replaced it for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was tasked to create an adapter for Tauri. Here is my attempt at it. Since the Tauri communication bridge between JS and Rust is async, I pretty much took the Node adapter and promisified every operation. Along with some other changes.
Code is not 100% ready to be merged as I wasn't sure what's the best way to expose this driver (as some of the calls are hardcoded for node). But at least I thought leaving it here doesn't hurt.