Feat: make the attribute instantiation more resistant to undefined attributes #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
make the attribute instanciation more resistant to undefined attributes
dreadkopp
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when using attributes on i.e. a Controller or Method that does not exist during generation of the open-api spec, the generation will fail with an error.
Attributes that are missing might be
either some dev-dependency attributes that are stripped from the code base in production
or some external attributes like the Deprecated - Attribute from PHPStorm
For me it was a big project with various controllers - many many with deprecations. when trying to integrate the laravel-openapi package it will fail due to missing class for Deprecated-Attribute when scanning all controllers.
by checking the existence of the attributes class before creating a new instance we can prevent this error from happening.