Skip to content

Conversation

@mergehez
Copy link

when a function doesn't have php-doc, the package throws an exception.

image

this PR fixes this problem. I also made a small performance improvement by using the ternary operator

when a function doesn't have php-doc, the package throws an exception!
@TartanLeGrand
Copy link
Collaborator

LGTM! @mergehez fix your commit to respect https://www.conventionalcommits.org/en/v1.0.0/

@mergehez
Copy link
Author

the problem is the commit message which can't be changed. You can close this PR and make these changes yourself. Only two lines are changes

@TartanLeGrand
Copy link
Collaborator

the problem is the commit message which can't be changed. You can close this PR and make these changes yourself. Only two lines are changes

You can't amend your message ? 🤔

@TartanLeGrand TartanLeGrand merged commit 033d21c into Nova-Edge:main Mar 31, 2025
26 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants