fix: handle dict/list arguments in tool call validation#1114
Closed
Jah-yee wants to merge 1 commit intoNousResearch:mainfrom
Closed
fix: handle dict/list arguments in tool call validation#1114Jah-yee wants to merge 1 commit intoNousResearch:mainfrom
Jah-yee wants to merge 1 commit intoNousResearch:mainfrom
Conversation
When using llama-server (llama.cpp) as an OpenAI-compatible backend, tool call arguments may be returned as a dict or list instead of a string. This causes AttributeError: 'dict' object has no attribute 'strip' at the tool call argument validation. This fix normalizes dict/list arguments to JSON strings before the .strip() call, matching the existing pattern used elsewhere in the codebase (line ~1660). Fixes: NousResearch#1071
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When using llama-server (llama.cpp) as an OpenAI-compatible backend, tool call arguments may be returned as a dict or list instead of a string. This causes
AttributeError: 'dict' object has no attribute 'strip'at the tool call argument validation.Fix
This fix normalizes dict/list arguments to JSON strings before the
.strip()call, matching the existing pattern used elsewhere in the codebase (line ~1660).Changes
tc.function.argumentsbefore calling.strip()json.dumps()json.dumps()str()for other typesTesting
This fix follows the same pattern already used at line ~1660 in
run_agent.py.Related
Fixes: #1071