Skip to content

fix: notion-compat page title missing richtext causes convert failure #629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+1 −1
Open

fix: notion-compat page title missing richtext causes convert failure #629

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/notion-compat/src/convert-block.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,7 @@ export function convertBlock({
if (pageMap) {
const page = pageMap[block.id] as types.Page
if (page) {
if (page.properties.title) {
if (page.properties.title?.rich_text) {
compatBlock.properties.title = convertRichText(
(page.properties.title as any).rich_text
)
Comment on lines +228 to 231
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While the nullish coalescing operator (?.) prevents the error, it might be beneficial to add a more explicit check for the type of page.properties.title to ensure that it is indeed a rich_text object before attempting to access its rich_text property. This would add an extra layer of safety and prevent potential issues if the title property has an unexpected structure.

          if (
            page.properties.title &&
            typeof page.properties.title === 'object' &&
            'rich_text' in page.properties.title
          ) {
            compatBlock.properties.title = convertRichText(
              (page.properties.title as any).rich_text
            )
          }

Expand Down