Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mkdir.nvim, nix-develop.nvim, direnv.vim: init, blink-cmp: add source options, friendly-snippets source #667

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

alfarelcynthesis
Copy link
Contributor

Adds a few very simple plugins I use, as well as options for blink-cmp that I find useful.

I can split this into a couple PRs if that would be preferred.

Two blink-cmp options:

  • blink-cmp.sourcePlugins, for arbitrary blink-cmp completion sources
    • there is a three provided sources that I've tested, that are disabled by default.
      I'm not sure how to indicate in the docs that they are present without making them
      disappear as soon as any other sources are added.
  • blink-cmp.friendly-snippets.enable, for an alternate snippet source
    • friendly-snippets is automatically detected by blink-cmp, so it doesn't need the same
      handling as other options

I also snuck in some typo fixing in the release notes (in a separate commit).

Sanity Checking

  • I have updated the changelog as per my changes
  • I have tested, and self-reviewed my code
  • My changes fit guidelines found in hacking nvf
  • Style and consistency
    • I ran Alejandra to format my code (nix fmt)
    • My code conforms to the editorconfig configuration of the project
    • My changes are consistent with the rest of the codebase
  • If new changes are particularly complex:
    • My code includes comments in particularly complex areas
    • I have added a section in the manual
    • (For breaking changes) I have included a migration guide
  • Package(s) built:
    • .#nix (default package)
    • .#maximal
    • .#docs-html (manual, must build)
    • .#docs-linkcheck (optional, please build if adding links)
  • Tested on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin

Add a 👍 reaction to pull requests you find important.

github-actions bot pushed a commit that referenced this pull request Feb 26, 2025
Copy link

github-actions bot commented Feb 26, 2025

🚀 Live preview deployed from 53d0e79

View it here:

Debug Information

Triggered by: alfarelcynthesis

HEAD at: extra-plugins

Reruns: 319

NotAShelf
NotAShelf previously approved these changes Feb 26, 2025
Copy link
Owner

@NotAShelf NotAShelf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

CC @horriblename for blink-cmp side of things.

@alfarelcynthesis
Copy link
Contributor Author

alfarelcynthesis commented Feb 27, 2025

Some blink options moved around when it was updated so I'm not sure if this will work correctly if merged right now (as blink itself does not work on main, so I can't test how it will behave with the newer version once blink is fixed).

If no one else gets to it for a few days I might try and fix it.
It should essentially be moving cmdline completion options to a separate attrset instead of inside keymap and sources, and adding a new attrset for terminal completion settings.

@NotAShelf
Copy link
Owner

53d0e79 should fix blink on main, although I don't quite have it set up so I had to push the change with a quick dev configuration instead of an actual configuration.

@alfarelcynthesis
Copy link
Contributor Author

I'll give it a try on my end, hopefully will still work/just require most recent blink-ripgrep-nvim instead of the version I used.

Use a submodule to allow arbitrary source additions.
Automatically load sources that are enabled.
Automatically add enabled sources via blink-cmp setupOpts.
Prepopulate submodule with a few basic sources, disabled by default.
Just adds it to the environment.
blink-cmp will pick up on it automatically.
Also fixes a misaligned contributor name.
@alfarelcynthesis
Copy link
Contributor Author

alfarelcynthesis commented Feb 27, 2025

Works as expected, did still update blink-ripgrep.nvim as it works with the version of blink.cmp we have now (as well as rebasing on newest main).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants