neovim/init: add autocommand & autogroup APIs #656
Conversation
NotAShelf
force-pushed
the
neovim-basics
branch
from
b3b832f to
aa28e2a
Compare
NotAShelf
force-pushed
the
neovim-basics
branch
from
aa28e2a to
4afb2cc
Compare
NotAShelf
force-pushed
the
neovim-basics
branch
from
4afb2cc to
e41d2a4
Compare
NotAShelf
changed the title
| callback = mkOption { | ||
| type = nullOr luaInline; | ||
| default = null; | ||
| example = '' |
There was a problem hiding this comment.
perhaps add the lib.generators.mkLuaInline part?
There was a problem hiding this comment.
or make it a string and use apply to auto luaInline it
There was a problem hiding this comment.
I'm pretty sure null is converted to Lua correctly, and luaInline contains appropriate type-checking for non-null cases. Does this really need changing? I can't think of an edge case not caught by the current type.
|
|
||
| assertions = [ | ||
| { | ||
| assertion = builtins.all (cmd: !(cmd.command != null && cmd.callback != null)) cfg.autocmds; |
There was a problem hiding this comment.
is it required to have exactly one of them? if so, please use an xor
if not, I'd prefer cmd.command == null || cmd.callback == null but this is more a style nitpick
There was a problem hiding this comment.
Technically you can have an autocommand without either, but it doesn't make sense to.
Adds
vim.augroupsandvim.autocmdsas Nix-native APIs for defining autocommands and autogroups in Nix. The implementation is a bit hacky, and relies on Lua instead of Nix for resolving auto{cmd,group} tables but should work as intended. Basic testing yields no errors, but I'll know for sure after I convert all of my autocommands to the new format.