ui/edgy-nvim: init #380
Draft
ui/edgy-nvim: init #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diniamo
previously approved these changes
Sep 26, 2024
diniamo
previously requested changes
Sep 26, 2024
diniamo
requested changes
Sep 26, 2024
| config = mkIf cfg.enable { | ||
| vim = { | ||
| startPlugins = ["edgy-nvim"]; | ||
| pluginRC.edgy-nvim = entryBefore ["basic"] '' |
There was a problem hiding this comment.
This is incorrect, pluginRC doesn't have a section called basic. You can either:
- Use
entryAnywhere, which should be fine - Put the variables in
luaConfigRCinstead, and changeentryBeforetoentryAfter, since later takes precedence, and we want to be overriding the values in basic, if there are any.
Comment on lines
+18
to
+23
| -- Neovim options recommended by upstream. | ||
| -- Views can only be fully collapsed with the global statusline. | ||
| vim.o.laststatus = 3 | ||
| -- Default splitting will cause your main splits to jump when opening an edgebar. | ||
| -- To prevent this, set `splitkeep` to either `screen` or `topline`. | ||
| vim.o.splitkeep = "screen" |
There was a problem hiding this comment.
Not very important, but I'm not sure if comments are very useful/necessary in the generated lua file.
diniamo
reviewed
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for edgy.nvim