Skip to content
This repository has been archived by the owner on Apr 26, 2022. It is now read-only.

Remove String typehint in URL helper #534

Merged
merged 3 commits into from
Jul 29, 2019
Merged

Remove String typehint in URL helper #534

merged 3 commits into from
Jul 29, 2019

Conversation

supercid
Copy link
Member

@supercid supercid commented Jul 25, 2019 •
edited
Loading

Description

Remove wrongful method parameter type which is incompatible with PHP < 5.6

Related Issue

Closes #528

How Has This Been Tested?

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • I have assigned the correct milestone or created one if non existent.
  • I have correctly labeled this pull request.
  • I have linked the corresponding issue in this description.
  • I have updated the corresponding Jira ticket.
  • I have requested a review from at least 2 reviewers
  • I have checked the base branch of this pull request
  • I have checked my code for any possible security vulnerabilities

@supercid supercid self-assigned this Jul 25, 2019
@supercid supercid added the bug label Jul 25, 2019
@supercid supercid added this to the 3.11.3 milestone Jul 25, 2019
@supercid supercid marked this pull request as ready for review July 25, 2019 11:03
@olsi-qose olsi-qose requested a review from fairlane July 29, 2019 07:36
@olsi-qose olsi-qose merged commit 85a5b5b into master Jul 29, 2019
@olsi-qose olsi-qose deleted the hotfix/String-typehint branch July 29, 2019 07:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fairlane fairlane Awaiting requested review from fairlane

Assignees

@supercid supercid

Labels
bug
Projects
None yet
Milestone
3.11.3
Development

Successfully merging this pull request may close these issues.
2 participants
@supercid @olsi-qose