Skip to content
This repository has been archived by the owner on Apr 26, 2022. It is now read-only.

Hotfix/add to cart js function #532

Merged
merged 6 commits into from
Jul 24, 2019
Merged

Conversation

supercid
Copy link
Member

@supercid supercid commented Jul 22, 2019

Related Issue

Continues #529 which have not fixed the issue.

How Has This Been Tested?

    Nosto.addMultipleProductsToCart([
        {'productId' : '402', 'skuId' : '231'}, // Configurable
        {'productId' : '402', 'skuId' : '232'}, // Configurable
        {'productId' : '408', 'skuId' : '252'}, // Configurable
        {'productId' : '408', 'skuId' : '253'}, // Configurable
		{'productId' : '878', 'skuId' : '878'}, // Not visible individually, should not have link or photograph
		{'productId' : '339', 'skuId' : '339'} // Simple and visible, should have link and picture
    ], this);

Documentation:

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • I have assigned the correct milestone or created one if non existent.
  • I have correctly labeled this pull request.
  • I have linked the corresponding issue in this description.
  • I have updated the corresponding Jira ticket.
  • I have requested a review from at least 2 reviewers
  • I have checked the base branch of this pull request
  • I have checked my code for any possible security vulnerabilities
  • Squash on merge

@supercid supercid force-pushed the hotfix/add-to-cart-js-function branch from f3c5fe4 to b09021f Compare July 23, 2019 08:38
@supercid supercid marked this pull request as ready for review July 23, 2019 08:40
@supercid supercid self-assigned this Jul 23, 2019
@supercid supercid requested review from olsi-qose and mridang July 23, 2019 10:09
@supercid supercid added the bug label Jul 23, 2019
@supercid supercid added this to the 3.11.2 milestone Jul 23, 2019
@supercid supercid changed the base branch from develop to master July 23, 2019 10:57
@supercid supercid merged commit 07a5c5d into master Jul 24, 2019
@supercid supercid deleted the hotfix/add-to-cart-js-function branch July 24, 2019 12:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants