update field content handling #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
jonathannilsen
commented
Nov 21, 2024
jonathannilsen
commented
- Remove "trailing zero adjustment"
- Add a way to get the enum string corresponding to the field content
jonathannilsen
added a commit
to jonathannilsen/svada
that referenced
this pull request
Nov 21, 2024
See NordicSemiconductor#14, NordicSemiconductor#15, NordicSemiconductor#16 Signed-off-by: Jonathan Nilsen <[email protected]>
jonathannilsen
added a commit
to jonathannilsen/svada
that referenced
this pull request
Nov 21, 2024
See NordicSemiconductor#14, NordicSemiconductor#15, NordicSemiconductor#16 Signed-off-by: Jonathan Nilsen <[email protected]>
57300
approved these changes
Nov 21, 2024
This makes it possible to for example retrieve the enum name that was set using Field.content. Signed-off-by: Jonathan Nilsen <[email protected]>
svada should not try to guess what the user meant - instead an error should be raised if an invalid input is given. The trailing zero adjustment also only worked with content that was padded with 4*N zero bits, so it did not work for general input. Signed-off-by: Jonathan Nilsen <[email protected]>
jonathannilsen
force-pushed
the
field-content-enum
branch
from
97db78d
to
fbefb0c
Compare
|
Updated the error message in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.