Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a new source with script or GitHub action #977

Merged
merged 2 commits into from
Feb 18, 2025

Conversation

datenreisender
Copy link
Contributor

Part of NCD-795:

Add script and GitHub Actions workflow to create a source.

The added description field is not yet used, but the idea is to already maintain it and eventually show it in the launcher.

Because there now exists a create-source script, it is not necessary any
more to do this here.
Copy link
Contributor

@boundlesscalm boundlesscalm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I'm a bit worried that we will forget the context this was created in and feel like just creating the source if it doesn't exist would be nicer, I do think it is better to have this as an explicitly separate action.
Makes it so that we have to do this consciously, and in the worst case it is also a fail-safe if we give it the wrong source to upload to.

@datenreisender datenreisender merged commit f9b50f6 into main Feb 18, 2025
3 checks passed
@datenreisender datenreisender deleted the artifactory/create_source branch February 18, 2025 08:22
@datenreisender
Copy link
Contributor Author

@boundlesscalm I also mentioned this action and script in the documentation about releasing an app, making it more likely to remember that we have it: https://nordicsemi.atlassian.net/wiki/spaces/WYLND/pages/1363739420/nRF+Connect+for+Desktop+App+Release+Procedure#Release-to-an-unforeseen-source

And even if we forgot this is here or why and e.g. we rather create a source manually by creating a source.json in the right place, I see little harm in having this action/script.

Also, if I really do create a new UX for adding sources (NCD-1188) I probably will add new metadata on Artifactory to find all available sources, which will make this script even more valuable to use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants