Feedback modal: generic handle error

[KievDevel]

Generic error message (API does not respond / network error):

[greg-fer]

Maybe:

"Use the form below" > "Please write below how we can make this application better."

To narrow down the scope of the feedback we want (this app).

And:

"Send feedback" > "Send"

[boundlesscalm]

LGTM

[boundlesscalm]

Maybe just me but I feel like a ternary expression makes this a bit harder to read.

Suggested change

	{errorMessage ? (
	<p className="tw-mb-0 tw-mt-1 tw-text-right tw-text-xs tw-text-red">
	{errorMessage}
	</p>
	) : null}
	{!!errorMessage && (
	<p className="tw-mb-0 tw-mt-1 tw-text-right tw-text-xs tw-text-red">
	{errorMessage}
	</p>
	)}

[KievDevel]

I do this way because some engines can produce bugs because of expression rendering false / undefined.
Remix JS and React Native have this issue so I better be safe :) Our setup seems ok, but that's more as a new habit.

With the readability part I agree

[datenreisender]

Instead of Mias double negation, a simple negation and || should also work:

Suggested change

	{errorMessage ? (
	<p className="tw-mb-0 tw-mt-1 tw-text-right tw-text-xs tw-text-red">
	{errorMessage}
	</p>
	) : null}
	{!errorMessage || (
	<p className="tw-mb-0 tw-mt-1 tw-text-right tw-text-xs tw-text-red">
	{errorMessage}
	</p>
	)}

(In my head I am reading this as “Either there is no error message or you output the error message”)

But I am fine with all three variants.

[ketile]

• In addition to saying "an error occurred" we should state what the error is as best we can.
• If "try again" does not solve the issue we should provide a link to support on DevZone.
• Consider adding some text that explicitly states feedback will not be answered.

@boundlesscalm has made a error/warning component for the Quickstart application which I think would be a good fit for this use case.

[datenreisender]

• What is the purpose of this callback, is there already a plan to use it somewhere (for what?)?
• Would it be helpful to also pass the error to it?
• Should its addition be mentioned in the changelog?

[KievDevel]

1. currently there is no way to know that any error happened outside of the handleFormData(). I could throw error next and catch later where the hook is called, but this sounds unsafe if hook is used elsewhere.
2. True, but looks unnecessary for this use case, can be added later if needed?
3. It is optional, doesn't break anything and most likely not needed for others, so I think no? Here I'm not sure

[KievDevel]

@ketile did you mean this one?

• Added a par. that feedback will not be answered.
• Slightly updated an error message. Error most likely on user side like being offline. rare edge case would be that feedback server API does not work. In both cases we're unable to submit.
• Used component from the quickstart

[greg-fer]

Please remove "Feedback will not be answered.".

• The feedback is by definition one way: "the transmission of evaluative or corrective information about an action, event, or process to the original or controlling source"
• The current phrasing of the sentence is direct and harsh.
• Including this message - which I haven't seen in any other feedback form elsewhere - can deter users from using this form.

[ketile]

@KievDevel Looks great with latest changes