Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CODEOWNERS file #940

Merged
merged 1 commit into from
Jan 18, 2024
Merged

Remove CODEOWNERS file #940

merged 1 commit into from
Jan 18, 2024

Conversation

aadnekar
Copy link
Contributor

Misunderstood the use case of CODEOWNERS. Thought it could require PRs to have at least one review from someone in CODEOWNERS in order to merge. But it seems to have a side effect.

It automatically sets the whole team to Reviewers when creating a PR, which is not desired.

Misunderstood the use case of CODEOWNERS. Thought it could require PRs
to have at least one review from someone in CODEOWNERS in order to
merge. But it seems to have a side effect.

It automatically sets the whole team to Reviewers when creating a PR,
which is not desired.
@aadnekar aadnekar added the doc not required All PRs either need "doc required" or "doc not required". label Jan 18, 2024
@aadnekar aadnekar requested a review from a team as a code owner January 18, 2024 12:54
@aadnekar aadnekar removed the request for review from a team January 18, 2024 12:54
@aadnekar aadnekar merged commit 09d7bbd into main Jan 18, 2024
7 checks passed
@aadnekar aadnekar deleted the remove-codeowners-file branch January 18, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc not required All PRs either need "doc required" or "doc not required".
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant