Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All PRs require doc_* label #939

Merged
merged 2 commits into from
Jan 18, 2024
Merged

All PRs require doc_* label #939

merged 2 commits into from
Jan 18, 2024

Conversation

aadnekar
Copy link
Contributor

Any given PR should either have the doc_required or doc_not_required label.

@aadnekar aadnekar requested a review from a team as a code owner January 18, 2024 11:37
@aadnekar aadnekar removed the request for review from a team January 18, 2024 11:38
@aadnekar aadnekar added the doc not required All PRs either need "doc required" or "doc not required". label Jan 18, 2024
Any given PR should either have the doc_required or doc_not_required
label.
@datenreisender
Copy link
Contributor

The existing label is doc-required (with a hyphen), not doc_required (with an underscore).

Labels also can have spaces in them, so how about using doc not required?

@aadnekar aadnekar merged commit f10d43a into main Jan 18, 2024
8 checks passed
@aadnekar aadnekar deleted the add-label-checker-action branch January 18, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc not required All PRs either need "doc required" or "doc not required".
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants