NCD-776: Limit voltage presets to fit the boards range #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
cybic
commented
Mar 7, 2024
cybic
commented
- Filtering out inapplicable voltage presets
- Refactor voltage preset buttons to functional components
- Make ready for preset values from board definition file
cybic
added
doc not required
boundlesscalm
approved these changes
Mar 7, 2024
Comment on lines
44
to
50
| const voltagePresetValues = [1200, 1800, 2000, 3300, 1600, 2400] | ||
| .filter( | ||
| filterVoltage => | ||
| filterVoltage >= voltageMin && filterVoltage <= voltageMax | ||
| ) | ||
| .slice(0, 3) | ||
| .sort((a, b) => a - b); |
There was a problem hiding this comment.
Not that it really matters, but why have unsorted presets only to explicitly sort them after?
There was a problem hiding this comment.
It does, in fact, matter :) The reason is to pick relevant voltage levels fro the different voltage ranges. I slice of the tree first elements to pick the most relevant fitting the range, and finally sort them to make the UI nice.
Good catch, though! 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.