Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/shared 166 #66

Merged
merged 3 commits into from
Mar 6, 2024
Merged

Feat/shared 166 #66

merged 3 commits into from
Mar 6, 2024

Conversation

kylebonnici
Copy link
Contributor

@kylebonnici kylebonnici commented Mar 5, 2024

@cybic give the app a spin as shared has changes with regards to some components

Reason for updating shared: due to a bug in nfutil core 7.7.0 - shared now can update core for users during sandbox init if any updates are available

@kylebonnici kylebonnici requested a review from cybic March 5, 2024 23:11
@kylebonnici kylebonnici added doc not required All PRs either need "doc required" or "doc not required". ui not required All PRs either need "ui required" or "ui not required". labels Mar 5, 2024
Copy link

github-actions bot commented Mar 5, 2024

Add labels:

  • 'doc required' or 'doc not required'
  • 'ui required' or 'ui not required'

For UI review:

  • describe the changes
  • add pictures
  • add the relevant UI responsible(s) as a reviewer

@cybic cybic force-pushed the feat/shared-166 branch from 61f0bad to b85ca8a Compare March 6, 2024 13:09
Copy link
Contributor

@cybic cybic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cybic cybic merged commit e615c36 into main Mar 6, 2024
3 checks passed
@cybic cybic deleted the feat/shared-166 branch March 6, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc not required All PRs either need "doc required" or "doc not required". ui not required All PRs either need "ui required" or "ui not required".
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants