Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NCD-748: Name PMIC ports #63

Merged
merged 4 commits into from
Mar 6, 2024
Merged

NCD-748: Name PMIC ports #63

merged 4 commits into from
Mar 6, 2024

Conversation

cybic
Copy link
Contributor

@cybic cybic commented Mar 5, 2024

Add name and description to PMIC ports

@cybic cybic added doc not required All PRs either need "doc required" or "doc not required". ui not required All PRs either need "ui required" or "ui not required". labels Mar 5, 2024
@cybic cybic requested a review from boundlesscalm March 5, 2024 14:32
@boundlesscalm
Copy link
Contributor

I feel like you can just merge prs like that. Spelling is tested by types (i believe?)
Unless I misunderstand what I should review.

@cybic cybic merged commit e9371a0 into main Mar 6, 2024
3 checks passed
@cybic cybic deleted the NCD-748_pmic_port_naming branch March 6, 2024 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc not required All PRs either need "doc required" or "doc not required". ui not required All PRs either need "ui required" or "ui not required".
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants