Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NCD-747: Refactor definition loading, add "Reset to default" button #58

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

cybic
Copy link
Contributor

@cybic cybic commented Feb 27, 2024

  • Refactor arbritation/selection of board configuration definitions. Prepare for dynamic loading of json-files.
  • Make default configuration part of config slice
  • Add a "Reset to board default"-button to the sidebar.

Doc notes: This PR adds a button to sidebar
image

 * Refactor arbritation/selection of board configuration definitions.
   Prepare for dynamic loading of json-files.
 * Make default configuration part of config slice
 * Add a "Reset to board default"-button to the sidebar.
@cybic cybic added doc required This PR includes user-facing changes that need to be documented. ui not required All PRs either need "ui required" or "ui not required". labels Feb 27, 2024
@cybic cybic requested a review from boundlesscalm February 28, 2024 07:14
Copy link
Contributor

@boundlesscalm boundlesscalm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cybic cybic merged commit 0d791f8 into main Feb 28, 2024
5 checks passed
@cybic cybic deleted the NCD-747_reset_button branch February 28, 2024 09:49
greg-fer added a commit that referenced this pull request Feb 29, 2024
Updated documentaton for the v0.1.8 release.
NCD-767, NCD-747, and PR #58.

Signed-off-by: Grzegorz Ferenc <[email protected]>
@greg-fer greg-fer mentioned this pull request Feb 29, 2024
3 tasks
greg-fer added a commit that referenced this pull request Feb 29, 2024
Updated documentaton for the v0.1.8 release.
NCD-767, NCD-747, and PR #58.

Signed-off-by: Grzegorz Ferenc <[email protected]>
greg-fer added a commit that referenced this pull request Mar 5, 2024
Updated documentaton for the v0.1.8 release.
NCD-767, NCD-747, and PR #58.

Signed-off-by: Grzegorz Ferenc <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc required This PR includes user-facing changes that need to be documented. ui not required All PRs either need "ui required" or "ui not required".
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants