Migrate to uniffi v0.28.3 #65
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 15, 2025 11:07
Signed-off-by: povilas.nagrockas <[email protected]>
Task: LLTDEVOPS-504 Got bindgen code to compile with uniffi v0.28.3, by disabling conflicting areas Signed-off-by: povilas.nagrockas <[email protected]>
packgron
force-pushed
the
LLTDEVOPS-503_migrate_to_v0.28
branch
from
95fac4a to
f02cd6d
Compare
Task: LLTDEVOPS-505 Added back generation form cdylib. Removed no_format field from BindingsGeneratorGo as formating option is now part of settings passed to generator iterface. Switched back to v0.28.0 as v0.28.3 has some interface changes to library_mode::generate_bindings.
Logic basicaly coppied from upstream swift bridging header. See: https://github.com/mozilla/uniffi-rs/blob/cd38ccea8236df7d93aff336c325a3a8e524af5d/uniffi_bindgen/src/bindings/swift/templates/BridgingHeaderTemplate.h Currently enshuring that bindgen does not panic for fixture binding generation that do not use new WithForeign traits.
Task: LLTDEVOPS-510 v0.25.0 -> v0.28.0 broke how RustBuffer stores length and capacity, now using uint64_t instead of int32_t. This commit fixes this in go and c bridging code. Part of basic test fixtures are now passing.
Task: LLTDEVOPS-511 v0.25.0 -> v0.28 switched to using pointers to Arc<T> for objects. This forces foreign language binding to use cloning semantics then lowering this pointer to rust.
Previously func was used instead of cons that leaks from macro function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrating go binding to uniffi v0.28.3