Cleanup callback code and test callback lifetimes #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) Test callback lifetime. Equivalent of mozilla/uniffi-rs#2230 The code looks like it should have the equivalent issue as NordSecurity/uniffi-bindgen-cs#79, but because pointers were taken to local variables, each pointer was unique, and received a unique handle. 2) Store generic type directly in concurrentHandleMap, not via pointer. Remove `rightMap`, as it actually doesn't do anything, and only creates issues. (NordSecurity/uniffi-bindgen-cs#79) Signed-off-by: Kristupas Antanavičius <[email protected]>
arg0d
force-pushed
the
kristupas/callback-reference-lifetimes
branch
from
fb12940 to
a7b2ef4
Compare
Savolro
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code looks like it should have the equivalent issue as NordSecurity/uniffi-bindgen-cs#79, but because pointers were taken to local variables, each pointer was unique, and received a unique handle.
rightMap, as it actually doesn't do anything, and only creates issues. (Dropping single callback reference invalidates the entire callback uniffi-bindgen-cs#79)