Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to uniffi @0.24 #13

Closed
wants to merge 65 commits into from
Closed

Upgrade to uniffi @0.24 #13

Show file tree
Hide file tree
Changes from 62 commits
Commits
Show all changes
65 commits
Select commit Hold shift + click to select a range
59fe5b3
start upgrade
dignifiedquire Aug 24, 2023
332306c
update template logic
dignifiedquire Aug 24, 2023
20d4c43
update deps
dignifiedquire Sep 13, 2023
47fd164
import additional fixtures
dignifiedquire Sep 13, 2023
887906f
stub in new features and templates
dignifiedquire Sep 13, 2023
73e1d4a
fix binding name
dignifiedquire Sep 13, 2023
3152346
stub in and update test files
dignifiedquire Sep 13, 2023
b393312
fix some rendering issues
dignifiedquire Sep 13, 2023
6825052
basic support for bytes
dignifiedquire Sep 14, 2023
18d6098
stub out foreign exectuor types
dignifiedquire Sep 14, 2023
eab4932
test import fixes
dignifiedquire Sep 14, 2023
9a4a554
tests compile
dignifiedquire Sep 15, 2023
51fd2e9
simplify RustBuffer handling
dignifiedquire Sep 15, 2023
3d44a78
update to new callback interface
dignifiedquire Sep 15, 2023
83795d1
debugging and some fixes for callbacks
dignifiedquire Sep 17, 2023
6cef98b
update callback constants
dignifiedquire Sep 18, 2023
66163ad
fix slice passing
dignifiedquire Sep 18, 2023
66c5dc3
cleanup some debugging
dignifiedquire Sep 18, 2023
e97161e
fix bytes helper impl
dignifiedquire Sep 18, 2023
2e2213d
eixsting tests passing
dignifiedquire Sep 18, 2023
47f9f36
cleanups
dignifiedquire Sep 18, 2023
fbe51a0
large reworking, almost got external types working
dignifiedquire Sep 20, 2023
2231e19
external types tests passing
dignifiedquire Sep 20, 2023
3d473b8
use unsafe.Slice for more efficient reader generation
dignifiedquire Sep 20, 2023
6c435b2
update to latest of uniffi-rs
dignifiedquire Sep 21, 2023
bb46ebb
implement library mode and make simple_fn tests pass
dignifiedquire Sep 21, 2023
3c6c0fe
start work on fixing proc_macro
dignifiedquire Sep 21, 2023
f45911a
fix bytes implementation
dignifiedquire Sep 21, 2023
f2d31eb
finish proc macro tests
dignifiedquire Sep 21, 2023
33f7222
implement and fix basic trait methods
dignifiedquire Sep 21, 2023
5bb82a5
simple iface test
dignifiedquire Sep 21, 2023
5e53b27
start compiling futures tests
dignifiedquire Sep 21, 2023
f17c97c
type limits test
dignifiedquire Sep 21, 2023
de7a9a1
implement (failing) test: foreign executor
dignifiedquire Sep 22, 2023
f3349d9
start setting up registry for foreign executors
dignifiedquire Sep 22, 2023
141af7e
implement foreign exeuctor basics (tests passing)
dignifiedquire Sep 22, 2023
1396b61
implement basic future test
dignifiedquire Sep 22, 2023
a4b281d
futures test compile
dignifiedquire Sep 22, 2023
f022bb0
basic future tests passing
dignifiedquire Sep 22, 2023
d8d7ce3
faster tests
dignifiedquire Sep 22, 2023
7fd2f6e
finish future tests impl
dignifiedquire Sep 22, 2023
63c56c5
cleanup import handling and remove some dead code
dignifiedquire Sep 22, 2023
ce07032
improve code type for primitive
dignifiedquire Sep 22, 2023
3e1f700
update to latest version of uniffi-rs
dignifiedquire Sep 22, 2023
8af51dd
cleanup generated code
dignifiedquire Sep 23, 2023
cc7d3b5
apply CR
dignifiedquire Sep 23, 2023
02903a8
refactor: improve conversion function name
dignifiedquire Sep 23, 2023
d41dc1e
fix: make sure cgo.Handle handling passes checkptr
dignifiedquire Sep 26, 2023
39d6727
test: fix race condition in callbacks_test
dignifiedquire Sep 26, 2023
784a2d4
Merge remote-tracking branch 'upstream/main' into upgarde-uniffi-24
dignifiedquire Sep 26, 2023
d93ff3c
ci: update rust version
dignifiedquire Oct 2, 2023
ca1a9f3
improve documentation and simplify some code
dignifiedquire Oct 2, 2023
5a0cf9a
split up ci scripts
dignifiedquire Oct 2, 2023
c28cdb7
run ci on test branch
dignifiedquire Oct 2, 2023
7714f1d
ci fixes
dignifiedquire Oct 2, 2023
9c0745c
CR: move lower_fn_call to macros.go
dignifiedquire Oct 2, 2023
c59edad
feat: implement function checksumming
dignifiedquire Oct 2, 2023
eef341b
ci: path fix
dignifiedquire Oct 2, 2023
2fa1f81
ci..
dignifiedquire Oct 2, 2023
ab30368
ci..
dignifiedquire Oct 2, 2023
0158272
test: allow for more delay
dignifiedquire Oct 2, 2023
2af2f21
docs: fixup readme
dignifiedquire Oct 2, 2023
7373888
apply latest CR
dignifiedquire Oct 3, 2023
2f69695
improved naming in panic
dignifiedquire Oct 3, 2023
086e8c1
fix: improved default value definition
dignifiedquire Nov 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 16 additions & 8 deletions .github/workflows/rust.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: Rust

on:
push:
branches: [ "main" ]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Undo this before merge

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

branches: [ "main", "upgarde-uniffi-24"]
pull_request:
branches: [ "main" ]

Expand All @@ -13,18 +13,23 @@ jobs:
build:
runs-on: ubuntu-latest
container:
image: rust:1.64
image: rust:1.70
steps:
- uses: actions/checkout@v3
with:
submodules: 'true'
- name: Build
- name: Build Bindgen
run: ./build.sh
- name: Generate Test Bindings
run: ./build_bindings.sh
- uses: actions/upload-artifact@v3
with:
name: lib
path: target/debug/libuniffi_fixtures.so
- uses: actions/upload-artifact@v3
with:
path: |
target/debug/libuniffi_fixtures.so
target/debug/uniffi-bindgen-go
name: bindings
path: binding_tests/generated/

test-bindings:
runs-on: ubuntu-latest
Expand All @@ -37,9 +42,12 @@ jobs:
submodules: 'true'
- uses: actions/download-artifact@v3
with:
name: artifact
name: lib
path: target/debug
- uses: actions/download-artifact@v3
with:
name: bindings
path: binding_tests/generated
- name: Test
run: |
chmod +x target/debug/uniffi-bindgen-go
./test_bindings.sh
2 changes: 1 addition & 1 deletion .gitmodules
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
[submodule "3rd-party/uniffi-rs"]
path = 3rd-party/uniffi-rs
url = https://github.com/NordSecurity/uniffi-rs.git
url = https://github.com/mozilla/uniffi-rs.git
2 changes: 1 addition & 1 deletion 3rd-party/uniffi-rs
Open in desktop
Submodule uniffi-rs updated 571 files
Loading