Fix ErrorTemplate for variants with empty fields (#14)

Signed-off-by: Luka Zakrajšek <[email protected]>
NordSecurity · Aug 30, 2023 · 95b8d9d · 95b8d9d
1 parent d4efb57
commit 95b8d9d
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 1 deletion.
diff --git a/bindgen/templates/ErrorTemplate.go b/bindgen/templates/ErrorTemplate.go
@@ -58,7 +58,7 @@ func (err {{ variant_class_name }}) Error() string {
 {%- else %}
 func (err {{ variant_class_name }}) Error() string {
 	return fmt.Sprint("{{ variant.name()|class_name }}",
-		{% if !variant.fields().is_empty() %}": "{% endif %},
+		{% if !variant.fields().is_empty() %}": ",{% endif %}
 		{%- for field in variant.fields() %}
 		{% if !loop.first %}", ",{% endif %}
 		"{{ field.name()|field_name }}=",

diff --git a/fixtures/errors/src/errors.udl b/fixtures/errors/src/errors.udl
@@ -24,6 +24,7 @@ interface ValidationError {
   InvalidUser(i32 user_id);
   InvalidMessage(string message);
   InvalidUserAndMessage(i32 user_id, string message);
+  UnknownError();
 };
 
 [Error]

diff --git a/fixtures/errors/src/lib.rs b/fixtures/errors/src/lib.rs
@@ -20,6 +20,8 @@ pub enum ValidationError {
     InvalidMessage { message: String },
     #[error("Invalid user {user_id} and message {message}")]
     InvalidUserAndMessage { user_id: i32, message: String },
+    #[error("Unknown error")]
+    UnknownError,
 }
 
 #[derive(Debug, thiserror::Error)]