Also use type casts for callbacks

Signed-off-by: Kegan Dougal <[email protected]>
NordSecurity · Mar 14, 2024 · 435c7e3 · 435c7e3
1 parent 2d69843
commit 435c7e3
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 1 deletion.
diff --git a/bindgen/templates/CallbackInterfaceTemplate.go b/bindgen/templates/CallbackInterfaceTemplate.go
@@ -69,7 +69,7 @@ func ({{ foreign_callback }}) {{ method_name }} (callback {{ type_name }}, args
 	{%- endmatch -%}
 	callback.{{ meth.name()|fn_name }}(
 		{%- for arg in meth.arguments() -%}
-		{{ arg|read_fn }}(reader)
+		{{ arg|read_fn }}(reader){{arg|error_type_cast}}
 		{%- if !loop.last %}, {% endif -%}
 		{%- endfor -%}
 		);

diff --git a/fixtures/errors/src/errors.udl b/fixtures/errors/src/errors.udl
@@ -51,6 +51,10 @@ dictionary Vec2 {
     double y;
 };
 
+callback interface Callback {
+    void do_something(BoobyTrapError error);
+};
+
 namespace errors {
 
   [Throws=BoobyTrapError]

diff --git a/fixtures/errors/src/lib.rs b/fixtures/errors/src/lib.rs
@@ -57,6 +57,10 @@ pub struct Vec2 {
     y: f64,
 }
 
+pub trait Callback {
+    fn do_something(&self, error: BoobyTrapError);
+}
+
 impl Vec2 {
     pub fn new(x: f64, y: f64) -> Vec2 {
         Vec2 { x, y }