Expand local workflow to include Windows users #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chloe McKnight <[email protected]>
Signed-off-by: Chloe McKnight <[email protected]>
Signed-off-by: Chloe McKnight <[email protected]>
arg0d
approved these changes
Nov 21, 2024
There was a problem hiding this comment.
Thanks for the PR, I've also tested on Mac and Windows. There seem to be additional test failures on Mac, but it's unrelated to these changes. I think the difference in DateTime exceptions is not that important at the moment, but I've created an issue to keep track of it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes it easier for contributors using Windows (using git-bash to execute shell scripts) to run the local dev workflow. These changes have been tested on Mac, Windows, and WSL2.
Note: The commented out chronological assertion throws a different exception on unix-based systems vs Windows. I'm not sure what's going on there and didn't have time to track it down, but I would be happy to roll an issue.