Downgrade .NET framework target version 4.6.1 #77
Conversation
The generated bindings already support 4.6.1, update documentation and target framework version in test project settings. Signed-off-by: Kristupas Antanavičius <[email protected]>
arg0d
force-pushed
the
kristupas/downgrade-target-framework
branch
from
3311119 to
00d3763
Compare
| ```xml | ||
| <PropertyGroup> | ||
| <TargetFramework>net48</TargetFramework> | ||
| <TargetFramework>net461</TargetFramework> |
There was a problem hiding this comment.
Was there a requirement to support net461? I think it already reached end of life. Also as far as the .NET Framework is concerned all up-to-date Windows machines should be running the latest version anyway 🤷 . So net48 is fine.
FIY .NET Framework is coupled with Windows and its update cycle, dotnet on the other hand is cross-platform and is decoupled from windows.
There was a problem hiding this comment.
It was a requirement from either NordVPN or NordLayer app, I can't remember exactly but maybe NordLayer?
There was a problem hiding this comment.
This should be merged, I kinda forgot to merge it because generated code was already net461 compliant 😅 Actually it might have been NordVPN app installer that requires net461.
The generated bindings already support 4.6.1, update documentation and target framework version in test project settings.