Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: follow csharp conventions #63

Merged
merged 4 commits into from
Jan 4, 2024
Merged

refactor: follow csharp conventions #63

merged 4 commits into from
Jan 4, 2024

Conversation

meenzen
Copy link
Contributor

@meenzen meenzen commented Dec 29, 2023

  • rename solution and project files
  • adjust file namespaces
  • add a .editorconfig file
  • configure CSharpier code style
  • reformat code using csharpier
  • configure VS and Rider to set license header
  • update license headers

@meenzen meenzen force-pushed the refactor/csharp-conventions branch from b7205fd to 2a41df0 Compare December 29, 2023 14:00
arg0d
arg0d requested changes Jan 3, 2024
View reviewed changes
Copy link
Contributor

@arg0d arg0d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but CI run_unit_tests.sh is failing :(

dotnet-tests/UniffiCS.Tests/TestBigEndianStream.cs Outdated Show resolved Hide resolved
@meenzen
fix: remove unnecessary import
aa60157 
Signed-off-by: Samuel Meenzen <[email protected]>
@meenzen meenzen force-pushed the refactor/csharp-conventions branch from 6e4581d to aa60157 Compare January 3, 2024 18:47
@meenzen
Copy link
Contributor Author

meenzen commented Jan 3, 2024

I somehow missed this failure when testing. It's fixed now.

If you want I can consolidate the test projects in a followup PR.

@arg0d
Copy link
Contributor

arg0d commented Jan 4, 2024

If you want I can consolidate the test projects in a followup PR.

Sure, if you are up for that :D

@arg0d arg0d merged commit bebce29 into NordSecurity:main Jan 4, 2024
4 checks passed
@meenzen meenzen deleted the refactor/csharp-conventions branch January 4, 2024 18:46
@meenzen meenzen mentioned this pull request Jan 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arg0d arg0d arg0d approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@meenzen @arg0d