Fix topological sort of types #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Structurally recursive types were not considered. For example, if `enum Foo` had a variant with a field of type `Vec<Bar>`, `Foo` was not considered to depend on `Bar` even though it needs to so that definitions are in the right order in the generated C++ header. Resolves NordSecurity#43 Signed-off-by: Stephane Raux <[email protected]>
|
That's a good catch, cleaned up the ugly sorting code nicely as well, thank you for the contribution! |
|
Thank you for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Structurally recursive types were not considered. For example, if
enum Foohad a variant with a field of typeVec<Bar>,Foowas not considered to depend onBareven though it needs to so that definitions are in the right order in the generated C++ header.Resolves #43