Enum naming styles #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eclarations, default is `Google` This was causing problems on Windows platforms if the enum names were one of the defined names like `ERROR`, `DEBUG`, `TRUE`, `FALSE` etc Signed-off-by: Martynas Gurskas <[email protected]>
Signed-off-by: Martynas Gurskas <[email protected]>
Use the other enum style to verify that compilation is successful Signed-off-by: Martynas Gurskas <[email protected]>
Signed-off-by: Martynas Gurskas <[email protected]>
arg0d
approved these changes
Apr 11, 2024
Lipt0nas
force-pushed
the
enum_naming_styles
branch
from
fb5a8e1 to
8937246
Compare
Signed-off-by: Martynas Gurskas <[email protected]>
Lipt0nas
force-pushed
the
enum_naming_styles
branch
from
8937246 to
3a5b586
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.