Dereference optional object type #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`optional<shared_ptr<T>>` does not make sense for C++, since `shared_ptr<T>` can represent empty state by itself. The transformation is implemented in couple of steps: 1. Remove `optional<>` for type labels to make `optional<shared_ptr<T>>` appear as `shared_ptr<T>` where the optional type is referenced 2. To maintain RustBuffer ABI compatibility, optional converter converts from `optional<shared_ptr<T>>` to `shared_ptr<T>` while keeping the read/write logic for optional byte. Signed-off-by: Kristupas Antanavičius <[email protected]>
arg0d
force-pushed
the
kristupas/dereference-optional-object
branch
from
b2418b8 to
4355462
Compare
Lipt0nas
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
optional<shared_ptr<T>>does not make sense for C++, sinceshared_ptr<T>can represent empty state by itself.The transformation is implemented in couple of steps:
Remove
optional<>for type labels to makeoptional<shared_ptr<T>>appear asshared_ptr<T>where the optional type is referencedTo maintain RustBuffer ABI compatibility, optional converter converts from
optional<shared_ptr<T>>toshared_ptr<T>while keeping the read/write logic for optional byte.