Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update idna to 1.0.0 to fix RUSTSEC-2024-0421 #3

Merged
merged 15 commits into from
Dec 11, 2024
Merged

Update idna to 1.0.0 to fix RUSTSEC-2024-0421 #3

merged 15 commits into from
Dec 11, 2024

Conversation

tomaszklak
Copy link

ghztomash
ghztomash approved these changes Dec 10, 2024
View reviewed changes
Copy link

@ghztomash ghztomash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@tomaszklak tomaszklak force-pushed the idna-update branch 6 times, most recently from 26b67f5 to 0e7e2c6 Compare December 10, 2024 15:02
packgron
packgron approved these changes Dec 11, 2024
View reviewed changes
Copy link

@packgron packgron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1.0
NIT: What was the reason to change all these constants?

@tomaszklak
Copy link
Author

+1.0 NIT: What was the reason to change all these constants?

93.184.215.14 is the (new) IP address for www.example.com and trust-dns tests performs real dns requests.

@tomaszklak tomaszklak merged commit 8820402 into release/0.24.0 Dec 11, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@packgron packgron packgron approved these changes

@ghztomash ghztomash ghztomash approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tomaszklak @ghztomash @packgron