[LLT-4202] Make lookup return error in case of failure on forward #1
Conversation
|
Why are the workflow files removed? |
| .await; | ||
| .await | ||
| .map_err(|e| { | ||
| debug!("failed to send response: {}", e); |
There was a problem hiding this comment.
There was a patch added by Gytis that reduced the log levels from trust-dns, probably because of spam in logs. Every warn/error log was changed to debug.
There was a problem hiding this comment.
Is that the commit you are referring to: fe423f8 - it's a pity that we will never know why the change was made ;)
| answers: Box::<AuthLookup>::default(), | ||
| ns: Box::<AuthLookup>::default(), | ||
| soa: Box::<AuthLookup>::default(), | ||
| additionals: Box::<AuthLookup>::default(), |
|
I wrote the reason for removing the workflow files in the commit description: "There are clippy warnings due to rust updates and some tests are failing |
Make the forward error visible instead of just filling the response buffer with an empty response.
dfetti
force-pushed
the
LLT-4202-make-lookup-return-error-if-forward-fails
branch
from
1681096 to
2522c02
Compare
| pub(crate) fn unknown(id: u16) -> Self { | ||
| let mut header = Header::new(); | ||
| header.set_id(id); | ||
| header.set_response_code(ResponseCode::Unknown(0)); |
There was a problem hiding this comment.
There are predefined ranges for the Unknown enum variant: https://github.com/NordSecurity/trust-dns/blob/main/crates/proto/src/op/response_code.rs#L125-L130
I think what is not clear is (at least for me) why was the decision made to remove the tests instead of fixing them. |
dfetti
force-pushed
the
LLT-4202-make-lookup-return-error-if-forward-fails
branch
from
2522c02 to
c69e15c
Compare
dfetti
force-pushed
the
LLT-4202-make-lookup-return-error-if-forward-fails
branch
5 times, most recently
from
eed8f34 to
fac712d
Compare
dfetti
force-pushed
the
LLT-4202-make-lookup-return-error-if-forward-fails
branch
from
fac712d to
4bc78b7
Compare
Make the forward error visible instead of just filling the response buffer with an empty response.