Update separator functionality #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added AddSeparatorID() which returns the item id. It can be used with the new ShowSeparator() and HideSeparator() methods to manipulate the separator behavior Signed-off-by: GrumpySurfer <[email protected]>
Savolro
requested changes
Nov 27, 2024
systray_menu_unix.go
Outdated
Comment on lines
242
to
252
| instance.menuLock.Lock() | ||
| defer instance.menuLock.Unlock() | ||
| menu, _ := findLayout(int32(parent)) | ||
| for _, i := range menu.V2 { | ||
| item := i.Value().(*menuLayout) | ||
| if item.V0 == int32(id) { | ||
| item.V1["visible"] = dbus.MakeVariant(true) | ||
| refresh() | ||
| return | ||
| } | ||
| } |
There was a problem hiding this comment.
This function is exactly the same as hideSeparator only with the argument to dbus.MakeVariant() differ. Could the code be reused?
systray_menu_unix.go
Outdated
| func showSeparator(id uint32, parent uint32) { | ||
| instance.menuLock.Lock() | ||
| defer instance.menuLock.Unlock() | ||
| menu, _ := findLayout(int32(parent)) |
There was a problem hiding this comment.
Any reason for this to require menuLock to be acquired?
There was a problem hiding this comment.
This lock is used to protect maps inside the menuLayout object. It is used basically every time the menuLayout is changed. Do you think we can remove it here?
Signed-off-by: GrumpySurfer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The systray library provides a way to manage buttons. They can be shown and hidden at runtime. However, this does not apply to menu separators, which cannot be easily hidden. This leads to a situation where you can hide all buttons, but the separators are still visible, which is not a good look.
The intention of this PR is to provide a way to manage separators by returning their ID and using additional methods to show and hide them.